On 12/28/2013 02:33 AM, Li Zefan wrote: > On 2013/12/27 16:05, Daniel Borkmann wrote: >> On 12/27/2013 04:13 AM, Li Zefan wrote: ... >>> I'd suggest splitting cls_cgroup code into 2 parts. The first part >>> is to manage cgroupfs and classid, and should be put into net/core/ >>> and add a new config like NET_CGROUP_CLASSID for it. The second part >>> is specific cls_cgroup code. >> >> Sure, if this is wished, I'd do this as a follow-up as it doesn't affect >> any of this code in netfilter here. > > We should clean up the code before introducing a new feature, not the > other way. Hehe, quite honestly, I think this is YOUR opinion of a "cleanup", which makes the code actually more complicated, and it's not strictly needed. If you are so desperate about this separation, fine, I will do this, but again, I don't think it's *strictly* required for this. -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
