On Thu, Dec 12, 2013 at 10:35:36AM -0500, Tejun Heo wrote: > On Sat, Dec 07, 2013 at 11:58:05AM +0400, Vladimir Davydov wrote: > > We should not call cgroup_unload_subsys() if online_css() fails, because > > online_css() does not assign css to cgroup on failure, while > > offline_css() called from cgroup_unload_subsys() expects it is assigned. > > So let's call everything we need to rollback inline without involving > > cgroup_unload_subsys(). > > > > Signed-off-by: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx> > > Cc: Tejun Heo <tj@xxxxxxxxxx> > > Cc: Li Zefan <lizefan@xxxxxxxxxx> > > Applied to cgroup/for-3.13-fixes. Scrap that. I don't think we can fail css_online for the root css in 3.13-fixes and this would cause conflict with 3.14, so let's not commit it to 3.13-fixes. Vladimir, can you please respin the patch on top of cgroup/for-3.14 but make cgroup_unload_subsys() check whether css is actually there before calling offline so that it matches the usual offline path better? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
