On Wed, Dec 04, 2013 at 02:04:36PM +0800, Li Zefan wrote:
> > @@ -2353,10 +2338,18 @@ static int cgroup_file_open(struct inode *inode, struct file *file)
> > WARN_ON_ONCE(cfe->css && cfe->css != css);
> > cfe->css = css;
> >
> > - if (cft->open)
> > + if (cft->open) {
> > err = cft->open(inode, file);
> > - else
> > - err = single_open(file, cgroup_seqfile_show, cfe);
> > + } else {
> > + err = single_open_size(file, cgroup_seqfile_show, cfe,
> > + sizeof(struct cgroup_open_file));
>
> This is wrong.
>
> I guess you wanted to use single_open_private(), which doesn't exist.
Yeah, right, I got completely confused about what single_open_size()
was doing. Hah, so, I guess I'll just introduce the single callbacks
here using seq_open_private(). More on this in the next patch.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
