Re: cgroup attach task - slogging cpu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/09, Oleg Nesterov wrote:
>
> On 10/09, Li Zefan wrote:
> >
> > Anjana, could you revise the patch and send it out with proper changelog
> > and Signed-off-by? And please add "Cc: <stable@xxxxxxxxxxxxxxx> # 3.9+"
>
> Yes, Anjana, please!

Please note also that the PF_EXITING check has the same problem, it also
needs "goto next".

> > > check in the main loop. So Anjana was right (sorry again!), and we
> > > should probably do
> > > 
> > > 		ent.cgrp = task_cgroup_from_root(...);
> > > 		if (ent.cgrp != cgrp) {
> > > 			retval = flex_array_put(...);
> > > 			...
> > > 		}
> > > 
> > > 		if (!threadgroup)
> > > 			break;
> > > 
> > 
> > Or
> > 
> > do {
> > 	...
> > 	if (ent.cgrp == cgrp)
> > 		goto next;
> 
> Or this, agreed.
> 
> > > Or I am wrong again?
> >
> > No, you are not! :)
> 
> Thanks ;)
> 
> Oleg.

--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux