Re: [PATCH 3/7] cgroup: restructure the failure path in cgroup_write_event_control()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 31, 2013 at 04:17:06PM +0800, Li Zefan wrote:
> It uses a single label and checks the validity of each pointer. This
> is err-prone, and actually we once had a bug because one of the check
> was insufficient.
> 
> Use multi lables as we do in other places.
> 
> Signed-off-by: Li Zefan <lizefan@xxxxxxxxxx>

Hmm... I usually prefer mix of the two approaches as both extremes
tend to be pretty ugly when things get complex.  I don't mind the
conversion but can you please drop the no longer unnecessary NULL
assignments on variable definitions?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux