Re: [PATCH] cgroups: Do not show inactive devices in cgroups statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Wed, Jun 26, 2013 at 6:23 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> Hello,
>
> On Wed, Jun 26, 2013 at 05:37:38PM -0700, Anatol Pomozov wrote:
>> Bottom line: when we set weight for a device then it creates cfq_group
>> and initializes device stats with zero. Later that zero stat is shown
>> even if no activity happened on the device. Both CFQ and our custom IO
>> scheduler have this problem. And because we write set weight for all
>> devices in all cgroups we endup with a lot of zero useless stats.
>>
>> What is the right fix in this situation?
>
> Yeah, I think yours is fine.  You're just configuring each blkg during
> init.  Please just update the u64 case and repost.

Yep. But it looks like before 3.5 stats initialization was not tied to
device initialization.
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux