On Wed, Jun 05, 2013 at 04:08:10PM -0700, Andrew Morton wrote: > On Mon, 3 Jun 2013 23:29:41 +0400 Glauber Costa <glommer@xxxxxxxxxx> wrote: > > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Pass the node of the current zone being reclaimed to shrink_slab(), > > allowing the shrinker control nodemask to be set appropriately for > > node aware shrinkers. > > Again, some musings on node hotplug would be interesting. > > > --- a/drivers/staging/android/ashmem.c > > +++ b/drivers/staging/android/ashmem.c > > @@ -692,6 +692,9 @@ static long ashmem_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > > .gfp_mask = GFP_KERNEL, > > .nr_to_scan = 0, > > }; > > + > > + nodes_setall(sc.nodes_to_scan); > > hm, is there some way to do this within the initializer? ie: > > .nodes_to_scan = magic_goes_here(), Nothing obvious - it's essentially a memset call, so I'm not sure how that could be put in the initialiser... > Also, it's a bit sad to set bits for not-present and not-online nodes. Yup. Plenty of scope for future optimisation. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
