On Mon, May 06, 2013 at 12:00:06PM -0400, Vivek Goyal wrote: > On Fri, May 03, 2013 at 05:50:44PM -0700, Tejun Heo wrote: > > [..] > > + * qnode_on_self is used when bios are directly queued to this > > + * throtl_grp so that local bios compete fairly with bios > > + * dispatched from children. qnode_on_parent is used when bios are > > + * dispatched from this throtl_grp into its parent and will compete > > + * with the sibling qnode_on_parents and the parent's > > + * qnode_on_self. > > + */ > > + struct throtl_qnode qnode_on_self; > > + struct throtl_qnode qnode_on_parent; > > Do we need one throtl_qnode for each IO dir (read/write) so that we can > queue up the right direction throtl_node in right sq->queued[rw]. Yes, we do. Thanks for spotting it. Will post an updated version soon. -- tejun -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
