On Tue, Apr 23, 2013 at 12:22:08PM +0400, Glauber Costa wrote: > From: Glauber Costa <glommer@xxxxxxxxxxxxx> [...] > This patch extends that to also support in-kernel users. Yup, that is the next logical step. ;-) The patches look good to me, just one question... > @@ -227,7 +233,7 @@ void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, > * we account it too. > */ > if (!(gfp & (__GFP_HIGHMEM | __GFP_MOVABLE | __GFP_IO | __GFP_FS))) I wonder if we want to let kernel users to specify the gfp mask here? The current mask is good for userspace notifications, but in-kernel users might be interested in including (or excluding) different types of allocations, e.g. watch only for DMA allocations pressure? Thanks! Anton -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
