On 04/11/2013 06:06 AM, Tejun Heo wrote: > Hello, Li. > > On Wed, Apr 10, 2013 at 7:02 PM, Li Zefan <lizefan@xxxxxxxxxx> wrote: >> I remember Glauber once used the bind() callback to detect if cpuacct and >> cpu are mounted together and if so do some optimization. >> >> Then he gave up on it and just deprecated cpuacct, but then it was decided >> that it can't be decprecated and removed as that will break userspace. >> >> So mayber Glauber will want to use this callback again? > > There was a patchset which made cpu provide the same stats as cpuacct > if mounted together, which bitrotted while Peter was away. We probably > should resurrect those patches. I don't recall whether it used ->bind > or not. Glauber? > The patch didn't suffer any change in its last 2 iteractions, so I was just waiting for someone to apply =p (or well, say something) It re-uses the infrastructure that you built in cgroup.c to detect comounting, so it does not use bind. I must add that I used bind just because "it was already there", and at the time we were also quite concerned about not increasing even more the number of callbacks. It is a horrible interface IMHO. -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
