Hi Tejun, On Tue, Feb 19, 2013 at 04:20:16PM -0500, Aristeu Rozanski wrote: > On Tue, Feb 19, 2013 at 09:12:08PM +0000, Serge E. Hallyn wrote: > > Quoting Aristeu Rozanski (aris@xxxxxxxxxx): > > > + } else { > > > + /* > > > + * in the other possible cases: > > > + * root's behavior: allow, devcg's: deny > > > + * root's behavior: deny, devcg's: deny > > > + * the exception will be removed > > > + */ > > > > Technically this case isn't needed, right? Will the dev_exception_rm() > > also be done by revalidate_active_exceptions()? So it's safe (but > > not necessary) to drop the else here. Though the comment is very > > informative, and it might be worth keeping the code as is for clarity. > > that's correct, it'll end up being removed by > revalidate_active_exceptions(). if others have no objection, I'll keep > it > > Thanks for the reviews Serge, much appreciated did you pick this series up for 3.10 or you want me to resubmit? -- Aristeu -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html