Hello, Li. On Tue, Mar 5, 2013 at 11:15 PM, Li Zefan <lizefan@xxxxxxxxxx> wrote: > wqh->lock is used through out fs/eventfd.c. I don't know if currently there's > any kernel user using eventfd APIs in an irq handler, but at least that should > be allowed. > > wake_up() is also allowed to be called from irq handler? Yeah, well, we don't consider everything which uses wake_up() to be irq-safe. I'm not necessarily against making the lock irq-safe but at least the commit message is misleading as currently posted. I'd suggest looking at eventfd and see whether the wakeup could actually happen from irq context. If not, I don't know, I don't think it matters either way. It's not like it's a difficult one to detect with lockdep. -- tejun -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html