Hey,
Generally looks good to me although I haven't really delved into the
behavior (you're gonna be there for the fallouts, right?). Just some
minor comments.
> +static int propagate_behavior(struct dev_cgroup *devcg_root)
> +{
> + struct cgroup *root = devcg_root->css.cgroup, *pos;
> + struct dev_cgroup *parent, *devcg, *tmp;
> + int rc = 0;
> + LIST_HEAD(pending);
> +
> + rcu_read_lock();
> + cgroup_for_each_descendant_pre(pos, root) {
> + devcg = cgroup_to_devcgroup(pos);
> + if (is_devcg_online(devcg))
> + list_add_tail(&devcg->propagate_pending, &pending);
> + }
> + rcu_read_unlock();
I think it could be a good idea to factor out the above and document
what's going on and why.
Other than that,
Acked-by: Tejun Heo <tj@xxxxxxxxxx>
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
