Hey, Michal.
On Wed, Oct 31, 2012 at 04:55:14PM +0100, Michal Hocko wrote:
> > + /*
> > + * Only live parents can have children. Note that the liveliness
> > + * check isn't strictly necessary because cgroup_mkdir() and
> > + * cgroup_rmdir() are fully synchronized by i_mutex; however, do it
> > + * anyway so that locking is contained inside cgroup proper and we
> > + * don't get nasty surprises if we ever grow another caller.
> > + */
> > + if (!cgroup_lock_live_group(parent)) {
> > + err = -ENODEV;
> > + goto err_free;
> > + }
> > +
>
> I think this should be moved up before we try to allocate any memory.
> Or is your motivation to keep cgroup_lock held for shorter time?
> I could agree with that but a small comment would be helpful.
Then I have to change the error out path more and I'm not sure I wanna
call deactivate_super() under cgroup_mutex. It's just simpler this
way.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
