On Mon, Oct 01, 2012 at 03:32:42PM -0400, Vivek Goyal wrote:
> Currently CFQ has three IO classes, RT, BE and IDLE. At many a places we
> are calling workloads belonging to these classes as "prio". This gets
> very confusing as one starts to associate it with ioprio.
>
> So this patch just does bunch of renaming so that reading code becomes
> easier. All reference to RT, BE and IDLE workload are done using keyword
> "class" and all references to subclass, SYNC, SYNC-IDLE, ASYNC are made
> using keyword "type".
>
> This makes me feel much better while I am reading the code. There is no
> functionality change due to this patch.
>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
Acked-by: Tejun Heo <tj@xxxxxxxxxx>
> @@ -751,16 +751,16 @@ static enum wl_type_t cfqq_type(struct cfq_queue *cfqq)
> return SYNC_WORKLOAD;
> }
>
> -static inline int cfq_group_busy_queues_wl(enum wl_prio_t wl,
> +static inline int cfq_group_busy_queues_wl(enum wl_class_t wl_class,
> struct cfq_data *cfqd,
> struct cfq_group *cfqg)
> {
> - if (wl == IDLE_WORKLOAD)
> + if (wl_class == IDLE_WORKLOAD)
> return cfqg->service_tree_idle.count;
>
> - return cfqg->service_trees[wl][ASYNC_WORKLOAD].count
> - + cfqg->service_trees[wl][SYNC_NOIDLE_WORKLOAD].count
> - + cfqg->service_trees[wl][SYNC_WORKLOAD].count;
> + return cfqg->service_trees[wl_class][ASYNC_WORKLOAD].count
> + + cfqg->service_trees[wl_class][SYNC_NOIDLE_WORKLOAD].count
> + + cfqg->service_trees[wl_class][SYNC_WORKLOAD].count;
While at it, maybe move the operator to the end of the preceding line
like everybody else?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
