On Mon, Aug 20, 2012 at 12:10:09AM -0700, Hugh Dickins wrote: > Yes, it looks nice to me. I might have preferred more as inlines in > the header file to lower the slight init/evict overhead, and I don't > see why __simple_xattr_set() isn't using simple_xattr_alloc() in the > same way that shmem_xattr_set() used shmem_xattr_alloc(). But none > of that matters: > > Acked-by: Hugh Dickins <hughd@xxxxxxxxxx> I can submit additional patches to fix these. What functions you want inlined? On why __simple_xattr_set() is not using simple_xattr_alloc(), there's no reason to be that way, I missed it. Thanks for reviewing! -- Aristeu -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html