On Tue, Jul 03, 2012 at 03:31:26PM +0900, KAMEZAWA Hiroyuki wrote:
> (2012/06/28 20:05), Sha Zhengju wrote:
> > From: Sha Zhengju <handai.szj@xxxxxxxxxx>
> >
> > Similar to dirty page, we add per cgroup writeback pages accounting. The lock
> > rule still is:
> > mem_cgroup_begin_update_page_stat()
> > modify page WRITEBACK stat
> > mem_cgroup_update_page_stat()
> > mem_cgroup_end_update_page_stat()
> >
> > There're two writeback interface to modify: test_clear/set_page_writeback.
> >
> > Signed-off-by: Sha Zhengju <handai.szj@xxxxxxxxxx>
>
> Seems good to me. BTW, you named macros as MEM_CGROUP_STAT_FILE_XXX
> but I wonder these counters will be used for accounting swap-out's dirty pages..
>
> STAT_DIRTY, STAT_WRITEBACK ? do you have better name ?
Perhaps we can follow the established "enum zone_stat_item" names:
NR_FILE_DIRTY,
NR_WRITEBACK,
s/NR_/MEM_CGROUP_STAT_/
The names indicate that dirty pages for anonymous pages are not
accounted (by __set_page_dirty_no_writeback()). While the writeback
pages accounting include both the file/anon pages.
Ah then we'll need to update the document in patch 0 accordingly. This
may sound a bit tricky to the users..
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
