On 07/04/2012 04:29 PM, Kamezawa Hiroyuki wrote: > (2012/06/28 20:06), Sha Zhengju wrote: >> From: Sha Zhengju <handai.szj@xxxxxxxxxx> >> >> While memcg oom happening, the dump info is limited, so add this >> to provide memcg page stat. >> >> Signed-off-by: Sha Zhengju <handai.szj@xxxxxxxxxx> > Could you split this into a different series ? > seems good to me in general but...one concern is hierarchy handling. > > IIUC, the passed 'memcg' is the root of hierarchy which gets OOM. > So, the LRU info, which is local to the root memcg, may not contain any good > information. I think you should visit all memcg under the tree. > Yes, you're right! I did not handle hierarchy here, and just now I make a test case to prove this. I'll split it to another series later. Thanks for reviewing! Thanks, Sha -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
