On Thu 31-05-12 11:13:16, Aneesh Kumar K.V wrote: > On Wed, May 30, 2012 at 09:19:54PM -0400, Konrad Rzeszutek Wilk wrote: [...] > > > +static struct cgroup_subsys_state *hugetlb_cgroup_create(struct cgroup *cgroup) > > > +{ > > > + int idx; > > > + struct cgroup *parent_cgroup; > > > + struct hugetlb_cgroup *h_cgroup, *parent_h_cgroup; > > > + > > > + h_cgroup = kzalloc(sizeof(*h_cgroup), GFP_KERNEL); > > > + if (!h_cgroup) > > > + return ERR_PTR(-ENOMEM); > > > + > > > > No need to check cgroup for NULL? > > Other cgroups (memcg) doesn't do that. Can we really get NULL cgroup tere ? No we cannot. See cfa449461e67b60df986170eecb089831fa9e49a -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html