On Wed, 30 May 2012, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> > > The current use of VM_FAULT_* codes with ERR_PTR requires us to ensure > VM_FAULT_* values will not exceed MAX_ERRNO value. Decouple the > VM_FAULT_* values from MAX_ERRNO. > Yeah, but is there a reason for using VM_FAULT_HWPOISON_LARGE_MASK since that's the only VM_FAULT_* value that is greater than MAX_ERRNO? The rest of your patch set doesn't require this, so I think this change should just be dropped. (And PTR_ERR() still returns long, this wasn't fixed from my original review.) -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
