(2012/04/17 7:31), Tejun Heo wrote: > On Thu, Apr 12, 2012 at 08:20:06PM +0900, KAMEZAWA Hiroyuki wrote: >> +/* >> + * In hierarchical accounting, child's usage is accounted into ancestors. >> + * To move local usage to its parent, just forget current level usage. >> + */ >> +void res_counter_move_parent(struct res_counter *counter, unsigned long val) >> +{ >> + unsigned long flags; >> + >> + BUG_ON(!counter->parent); >> + spin_lock_irqsave(&counter->lock, flags); >> + res_counter_uncharge_locked(counter, val); >> + spin_unlock_irqrestore(&counter->lock, flags); >> +} > > On the second thought, do we need this at all? It's as good as doing > nothing after all, no? > I considered that, but I think it may make it hard to debug memcg leakage. I'd like to confirm res->usage == 0 at removal of memcg. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html