Re: [RFC v0 1/4] net: Only update sk_cgrp_prioidx on change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 16, 2012 at 05:35:03PM +0200, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
> 
> Do not make the cache line dirty when nothing has changed.
> sock_update_classid() does exactly the same thing.
> 
> Signed-off-by: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
> CC: Neil Horman <nhorman@xxxxxxxxxxxxx>
> CC: Tejun Heo <tj@xxxxxxxxxx>
> CC: Li Zefan <lizefan@xxxxxxxxxx>
> ---
>  net/core/sock.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/net/core/sock.c b/net/core/sock.c
> index c7e60ea..75c4b72 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -1190,10 +1190,14 @@ EXPORT_SYMBOL(sock_update_classid);
>  
>  void sock_update_netprioidx(struct sock *sk)
>  {
> +	u32 prioidx;
> +
>  	if (in_interrupt())
>  		return;
>  
> -	sk->sk_cgrp_prioidx = task_netprioidx(current);
> +	prioidx = task_netprioidx(current);
> +	if (prioidx != sk->sk_cgrp_prioidx)
> +		sk->sk_cgrp_prioidx = prioidx;
>  }
>  EXPORT_SYMBOL_GPL(sock_update_netprioidx);
>  #endif
> -- 
> 1.7.10.130.g36e6c
> 
> 

Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux