On Thu, Apr 12, 2012 at 04:29:33PM -0700, Tejun Heo wrote:
Hi Tejun,
> @@ -732,20 +732,21 @@ void blkio_policy_register(struct blkio_policy_type *blkiop)
> {
> struct request_queue *q;
>
> + mutex_lock(&blkcg_pol_mutex);
> +
> blkcg_bypass_start();
> - spin_lock(&blkio_list_lock);
>
> BUG_ON(blkio_policy[blkiop->plid]);
A minor nit. It might be a good idea to check that blkiop->plid is not
greater than BLKIO_NR_POLICIES for both registration and unresitration
functions to avoid touching memory beyond blkio_policy[] array.
Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
