(2012/04/10 7:36), Glauber Costa wrote: > The only reason cgroup was used, was to be consistent with the populate() > interface. Now that we're getting rid of it, not only we no longer need > it, but we also *can't* call it this way. > > Since we will no longer rely on populate(), this will be called from > create(). During create, the association between struct mem_cgroup > and struct cgroup does not yet exist, since cgroup internals hasn't > yet initialized its bookkeeping. This means we would not be able > to draw the memcg pointer from the cgroup pointer in these > functions, which is highly undesirable. > > Signed-off-by: Glauber Costa <glommer@xxxxxxxxxxxxx> > CC: Tejun Heo <tj@xxxxxxxxxx> > CC: Li Zefan <lizefan@xxxxxxxxxx> > CC: Kamezawa Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > CC: Johannes Weiner <hannes@xxxxxxxxxxx> > CC: Michal Hocko <mhocko@xxxxxxx> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html