On Wed, Mar 28, 2012 at 03:51:28PM -0700, Tejun Heo wrote: > blkio_group_conf->weight is owned by cfq and has no reason to be > defined in blkcg core. Replace it with cfq_group->dev_weight and let > conf setting functions directly set it. If dev_weight is zero, the > cfqg doesn't have device specific weight configured. > > Also, rename BLKIO_WEIGHT_* constants to CFQ_WEIGHT_* and rename > blkio_cgroup->weight to blkio_cgroup->cfq_weight. We eventually want > per-policy storage in blkio_cgroup but just mark the ownership of the > field for now. Hi Tejun, blkio_cgroup->weight can be thought of in a more generic manner and that is sytem wide cgroup weight. And more than one policy should be allowed to make use of it. That's a differnt thing that currently only CFQ makes use of it. For example, Fengguang posted RFC patches to try to make use of blkcg->weight and differentiate between buffered write bandwidth. https://lkml.org/lkml/2012/3/28/275 Thanks Vivek -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
