(2012/03/20 1:10), Tejun Heo wrote: > Hello, > > On Mon, Mar 19, 2012 at 01:26:02PM +0900, KAMEZAWA Hiroyuki wrote: >>> +CGROUP_SUBSYS_CFTYPES_COND(mem_cgroup_subsys, memsw_cgroup_files, >>> + really_do_swap_account); >> >> >> I'm sorry but why you use really_do_swap_account instead of do_swap_account ? > > Because do_swap_account is initialized too late. > CGROUP_SUBSYS_CFTYPES() are processed via fs_initcall(). AFAICS, > do_swap_account may not have been initialized by then. Also, if memcg > as whole is disabled, it doesn't matter whether those files are > registered or not, right? We probably need some comment there tho. > I think creating file based on really_do_swap_account is wrong. (I'm sorry for this complication.) How about creating this file unconditionally ? Returning -ENOTSUP in memcg's handler will work well...anyway it's configured, no reason to show them is bad. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
