On Fri, Dec 16, 2011 at 08:38:31AM -0800, Mandeep Singh Baines wrote: > We can now assume that the css_set reference held by the task > will not go away for an exiting task. PF_EXITING state can be > trusted throughout migration by checking it after locking > threadgroup. > > This patch depends on: > > commit cd3d095275374220921fcf0d4e0c16584b26ddbc > Author: Tejun Heo <tj@xxxxxxxxxx> > Date: Mon Dec 12 18:12:21 2011 -0800 > > cgroup: always lock threadgroup during migration > > Signed-off-by: Mandeep Singh Baines <msb@xxxxxxxxxxxx> > Cc: Tejun Heo <tj@xxxxxxxxxx> > Cc: Li Zefan <lizf@xxxxxxxxxxxxxx> > Cc: containers@xxxxxxxxxxxxxxxxxxxxxxxxxx > Cc: cgroups@xxxxxxxxxxxxxxx > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx> > Cc: Oleg Nesterov <oleg@xxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Paul Menage <paul@xxxxxxxxxxxxxx> > --- > kernel/cgroup.c | 25 ++++++------------------- > 1 files changed, 6 insertions(+), 19 deletions(-) > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 1b3b841..eb95e32 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -1856,7 +1856,6 @@ static int cgroup_task_migrate(struct cgroup *cgrp, struct cgroup *oldcgrp, > */ > task_lock(tsk); > oldcg = tsk->cgroups; > - get_css_set(oldcg); > task_unlock(tsk); Seems we don't need these task_lock() anymore. I'm cooking a patch to clean that up. -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
