Hello, On Sun, Dec 11, 2011 at 09:44:54PM +0100, Glauber Costa wrote: > On 12/11/2011 07:55 PM, KOSAKI Motohiro wrote: > > Can you please tell us which compiler failed automatic inlining? > > I suspect gcc is enough sane and we don't need this patch. > > Of course we don't need, that's the very definition of a "nitpick". > This patch is directed towards the reader, not the compiler. Maintainers > are free to take it or not, although I believe being explicit is better. These days, I don't think adding inline buys us much (other than explicit cases where always_inline or noinline is necessary). gcc already does good enough job for inlining and 'inline' hint seems more to hinder rather than help and I don't really see what it buys for code readers either, so I won't be taking this one. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
