That's correct - it's the removable flag that's causing the disks to be excluded. I actually just merged this PR last week: https://github.com/ceph/ceph/pull/49954 One of the changes it made was to enable removable (but not USB) devices, as there are vendors that report hot-swappable drives as removable. Patrick, it looks like this may resolve your issue as well. On Tue, Oct 24, 2023 at 5:57 AM Eugen Block <eblock@xxxxxx> wrote: > > Hi, > > > May be because they are hot-swappable hard drives. > > yes, that's my assumption as well. > > > Zitat von Patrick Begou <Patrick.Begou@xxxxxxxxxxxxxxxxxxxxxx>: > > > Hi Eugen, > > > > Yes Eugen, all the devices /dev/sd[abc] have the removable flag set > > to 1. May be because they are hot-swappable hard drives. > > > > I have contacted the commit author Zack Cerza and he asked me for > > some additional tests too this morning. I add him in copy to this > > mail. > > > > Patrick > > > > Le 24/10/2023 à 12:57, Eugen Block a écrit : > >> Hi, > >> > >> just to confirm, could you check that the disk which is *not* > >> discovered by 16.2.11 has a "removable" flag? > >> > >> cat /sys/block/sdX/removable > >> > >> I could reproduce it as well on a test machine with a USB thumb > >> drive (live distro) which is excluded in 16.2.11 but is shown in > >> 16.2.10. Although I'm not a developer I tried to understand what > >> changes were made in > >> https://github.com/ceph/ceph/pull/46375/files#diff-330f9319b0fe352dff0486f66d3c4d6a6a3d48efd900b2ceb86551cfd88dc4c4R771 and there's this > >> line: > >> > >>> if get_file_contents(os.path.join(_sys_block_path, dev, > >>> 'removable')) == "1": > >>> continue > >> > >> The thumb drive is removable, of course, apparently that is filtered here. > >> > >> Regards, > >> Eugen > >> > >> Zitat von Patrick Begou <Patrick.Begou@xxxxxxxxxxxxxxxxxxxxxx>: > >> > >>> Le 23/10/2023 à 03:04, 544463199@xxxxxx a écrit : > >>>> I think you can try to roll back this part of the python code and > >>>> wait for your good news :) > >>> > >>> > >>> Not so easy 😕 > >>> > >>> > >>> [root@e9865d9a7f41 ceph]# git revert > >>> 4fc6bc394dffaf3ad375ff29cbb0a3eb9e4dbefc > >>> Auto-merging src/ceph-volume/ceph_volume/tests/util/test_device.py > >>> CONFLICT (content): Merge conflict in > >>> src/ceph-volume/ceph_volume/tests/util/test_device.py > >>> Auto-merging src/ceph-volume/ceph_volume/util/device.py > >>> CONFLICT (content): Merge conflict in > >>> src/ceph-volume/ceph_volume/util/device.py > >>> Auto-merging src/ceph-volume/ceph_volume/util/disk.py > >>> CONFLICT (content): Merge conflict in > >>> src/ceph-volume/ceph_volume/util/disk.py > >>> error: could not revert 4fc6bc394df... ceph-volume: Optionally > >>> consume loop devices > >>> > >>> Patrick > >>> _______________________________________________ > >>> ceph-users mailing list -- ceph-users@xxxxxxx > >>> To unsubscribe send an email to ceph-users-leave@xxxxxxx > >> > >> > >> _______________________________________________ > >> ceph-users mailing list -- ceph-users@xxxxxxx > >> To unsubscribe send an email to ceph-users-leave@xxxxxxx > > > > _______________________________________________ > > ceph-users mailing list -- ceph-users@xxxxxxx > > To unsubscribe send an email to ceph-users-leave@xxxxxxx > > > _______________________________________________ ceph-users mailing list -- ceph-users@xxxxxxx To unsubscribe send an email to ceph-users-leave@xxxxxxx
 |