Re: Zabbix module Octopus 15.2.3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Reed, Gert, list,

On 28/07/2020 23:42, Reed Dier wrote:
> I'm going to resurrect this thread to throw my hat in the ring as I am
> having this issue as well.

Did not see any solutions to this thread (be it this one, or any thread
more recently) so forgive me for re-resurrecting this thread :-).

> I just moved to 15.2.4 on Ubuntu 18.04/bionic, and Zabbix is 5.0.2.
>> $ ceph zabbix config-show
>> Error EINVAL: Traceback (most recent call last):
>>   File "/usr/share/ceph/mgr/mgr_module.py", line 1167, in _handle_command
>>     return self.handle_command(inbuf, cmd)
>>   File "/usr/share/ceph/mgr/zabbix/module.py", line 407, in handle_command
>>     return 0, json.dumps(self.config, index=4, sort_keys=True), ''
>>   File "/usr/lib/python3.6/json/__init__.py", line 238, in dumps
>>     **kw).encode(obj)
>> TypeError: __init__() got an unexpected keyword argument 'index'
> 
> Which looks to be exactly the same as your error.

As I ran into this exact error as well, I dug a bit deeper in the source
code. Currently running ceph-mgr-modules-core on Octopus 15.2.6 / Ubuntu
20.04:

# ceph zabbix config-show
Error EINVAL: Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 1177, in _handle_command
    return self.handle_command(inbuf, cmd)
  File "/usr/share/ceph/mgr/zabbix/module.py", line 407, in handle_command
    return 0, json.dumps(self.config, index=4, sort_keys=True), ''
  File "/lib/python3.8/json/__init__.py", line 234, in dumps
    return cls(
TypeError: __init__() got an unexpected keyword argument 'index'

This bug was introduced here
<https://github.com/ceph/ceph/commit/0e9303d0599c92e575aae7acca87328ed8ee9527>,
where `index=4` was introduced, but it had to be `indent=4`.

It has been fixed in
<https://github.com/ceph/ceph/commit/ddceba1647096455a506a72d3bfe911e7e6e828a>
for pacific, as well as backported to octopus:
<https://github.com/ceph/ceph/commit/c40d97ae23d912532ad0c9330b0ed96b1477f20c>
via <https://github.com/ceph/ceph/pull/37128>.

Relevant bug tracker links:
* <https://tracker.ceph.com/issues/47426>
* <https://tracker.ceph.com/issues/47404>

On an updated git clone of <https://github.com/ceph/ceph>:

$ git tag --contains c40d97ae23d912532ad0c9330b0ed96b1477f20c | sort -V
v15.2.8
v15.2.9
v15.2.10
v15.2.11
v15.2.12

So, you could upgrade to at least 15.2.8 to have this bug fixed. Or:
simply patch the affected file /usr/share/ceph/mgr/zabbix/module.py (see
the backported commit
<https://github.com/ceph/ceph/commit/c40d97ae23d912532ad0c9330b0ed96b1477f20c>),
disable and enable the zabbix module:

# ceph mgr module disable zabbix
# ceph mgr module enable zabbix
# ceph zabbix config-show
{
    "discovery_interval": 100,
    "identifier": "ceph.redacted.local",
    "interval": 60,
    "log_level": "",
    "log_to_cluster": false,
    "log_to_cluster_level": "info",
    "log_to_file": false,
    "zabbix_host": "zabbix.redacted.local",
    "zabbix_port": 10051,
    "zabbix_sender": "/usr/bin/zabbix_sender"
}

Hope this helps.

Best regards,
Gerdriaan Mulder
_______________________________________________
ceph-users mailing list -- ceph-users@xxxxxxx
To unsubscribe send an email to ceph-users-leave@xxxxxxx




[Index of Archives]     [Information on CEPH]     [Linux Filesystem Development]     [Ceph Development]     [Ceph Large]     [Ceph Dev]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [xfs]


  Powered by Linux