On 17-06-21 03:24 PM, Sage Weil wrote: > On Wed, 21 Jun 2017, Piotr Dałek wrote: >> On 17-06-14 03:44 PM, Sage Weil wrote: >>> On Wed, 14 Jun 2017, Paweł Sadowski wrote: >>>> [snip] >>>> >>>> Is it safe to enable "filestore seek hole", are there any tests that >>>> verifies that everything related to RBD works fine with this enabled? >>>> Can we make this enabled by default? >>> >>> We would need to enable it in the qa environment first. The risk here is >>> that users run a broad range of kernels and we are exposing ourselves to >>> any bugs in any kernel version they may run. I'd prefer to leave it off >>> by default. >> >> That's a common regression? If not, we could blacklist particular kernels and >> call it a day. >>> We can enable it in the qa suite, though, which covers >>> centos7 (latest kernel) and ubuntu xenial and trusty. >> >> +1. Do you need some particular PR for that? > > Sure. How about a patch that adds the config option to several of the > files in qa/suites/rados/thrash/thrashers? Does https://github.com/ovh/ceph/commit/fe65e3a19470eea16c9d273d1aac1c7eff7d2ff1 look reasonably? -- Piotr Dałek piotr.dalek@xxxxxxxxxxxx https://www.ovh.com/us/ _______________________________________________ ceph-users mailing list ceph-users@xxxxxxxxxxxxxx http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
 |