> -----Original Message----- > From: Nick Fisk [mailto:nick@xxxxxxxxxx] > Sent: 12 February 2016 13:31 > To: 'Sage Weil' <sage@xxxxxxxxxxxx> > Cc: 'Jason Dillaman' <dillaman@xxxxxxxxxx>; 'Samuel Just' > <sjust@xxxxxxxxxx>; ceph-users@xxxxxxxxxxxxxx; ceph- > devel@xxxxxxxxxxxxxxx > Subject: RE: cls_rbd ops on rbd_id.$name objects in EC pool > > > -----Original Message----- > > From: ceph-devel-owner@xxxxxxxxxxxxxxx [mailto:ceph-devel- > > owner@xxxxxxxxxxxxxxx] On Behalf Of Sage Weil > > Sent: 12 February 2016 13:15 > > To: Nick Fisk <nick@xxxxxxxxxx> > > Cc: 'Jason Dillaman' <dillaman@xxxxxxxxxx>; 'Samuel Just' > > <sjust@xxxxxxxxxx>; ceph-users@xxxxxxxxxxxxxx; ceph- > > devel@xxxxxxxxxxxxxxx > > Subject: RE: cls_rbd ops on rbd_id.$name objects in EC pool > > > > On Thu, 11 Feb 2016, Sage Weil wrote: > > > On Thu, 11 Feb 2016, Nick Fisk wrote: > > > > That’s a relief, I was sensing a major case of face palm occuring > > > > when I read Jason's email!!! > > > > > > https://github.com/ceph/ceph/pull/7617 > > > > > > The tangled logic in maybe_handle_cache wasn't respecting the force > > > promotion bool. > > > > So, the cause on hammer was entirely different than on master. There > > we broke things during a refactor, but on hammer we just hadn't > > backported a fix. I've prepared a pull request for that: > > > > https://github.com/ceph/ceph/pull/7622 > > > > Nick, do you mind verifying that this fixes things for you? > > Yeah sure, I'm just running a few promotion benchmarks, but will get on it > afterwards. Sorry for the delay, but all looks good to me nick@Ceph-Test:~$ rbd -p ecpool create Test12 --size=10G nick@Ceph-Test:~$ rbd -p cache1 info Test12 rbd image 'Test12': size 10240 MB in 2560 objects order 22 (4096 kB objects) block_name_prefix: rbd_data.f2b484c56c6ba format: 2 features: layering flags: nick@Ceph-Test:~$ rados -p cache1 cache-flush rbd_id.Test12 nick@Ceph-Test:~$ rados -p cache1 cache-evict rbd_id.Test12 nick@Ceph-Test:~$ ceph osd pool set cache1 min_read_recency_for_promote 8 set pool 12 min_read_recency_for_promote to 8 nick@Ceph-Test:~$ rbd -p cache1 info Test12 rbd image 'Test12': size 10240 MB in 2560 objects order 22 (4096 kB objects) block_name_prefix: rbd_data.f2b484c56c6ba format: 2 features: layering flags: > > > > > sage _______________________________________________ ceph-users mailing list ceph-users@xxxxxxxxxxxxxx http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
 |