Re: [PATCH] ceph: exchange hardcoded value on NAME_MAX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 24, 2025 at 2:46 PM Viacheslav Dubeyko <slava@xxxxxxxxxxx> wrote:
>
> From: Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>
>
> Initially, ceph_fs_debugfs_init() had temporary
> name buffer with hardcoded length of 80 symbols.
> Then, it was hardcoded again for 100 symbols.
> Finally, it makes sense to exchange hardcoded
> value on properly defined constant and 255 symbols
> should be enough for any name case.
>
> Signed-off-by: Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>
> ---
>  fs/ceph/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index fdf9dc15eafa..fdd404fc8112 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -412,7 +412,7 @@ void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc)
>
>  void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
>  {
> -       char name[100];
> +       char name[NAME_MAX];
>
>         doutc(fsc->client, "begin\n");
>         fsc->debugfs_congestion_kb =
> --
> 2.48.0
>
>

Reviewed-by: Patrick Donnelly <pdonnell@xxxxxxx>

-- 
Patrick Donnelly, Ph.D.
He / Him / His
Red Hat Partner Engineer
IBM, Inc.
GPG: 19F28A586F808C2402351B93C3301A3E258DD79D






[Index of Archives]     [CEPH Users]     [Ceph Large]     [Ceph Dev]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux