On Wed, Jan 22, 2025 at 08:27:41PM +0000, David Howells wrote:
> Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> > - _enter("{%lu},%p{%pd},", dir->i_ino, dentry, dentry);
> > + _enter("{%lu},{%s},", dir->i_ino, name->name);
>
> I don't think that name->name is guaranteed to be NUL-terminated after
> name->len characters. The following:
>
> _enter("{%lu},{%*s},", dir->i_ino, name->len, name->name);
>
> might be better, though:
>
> _enter("{%lu},{%*.*s},", dir->i_ino, name->len, name->len, name->name);
>
> might be necessary.
Good catch (and that definitely needs to be documented in previous commit),
but what's wrong with
_enter("{%lu},{%.*s},", dir->i_ino, name->len, name->name);
After looking through the rest of the series, fuse and orangefs patches
need to be adjusted. Not caught in testing since there similar braino
manifests as stray invalidates ;-/
