David Howells wrote: > From: Zilin Guan <zilin@xxxxxxxxxx> > > The function netfs_unbuffered_write_iter_locked() in > fs/netfs/direct_write.c contains an unnecessary smp_rmb() call after > wait_on_bit(). Since wait_on_bit() already incorporates a memory barrier > that ensures the flag update is visible before the function returns, the > smp_rmb() provides no additional benefit and incurs unnecessary overhead. > > This patch removes the redundant barrier to simplify and optimize the code. > > Signed-off-by: Zilin Guan <zilin@xxxxxxxxxx> > Signed-off-by: David Howells <dhowells@xxxxxxxxxx> > cc: Akira Yokosawa <akiyks@xxxxxxxxx> Reviewed-by: Akira Yokosawa <akiyks@xxxxxxxxx> > cc: Jeff Layton <jlayton@xxxxxxxxxx> > cc: netfs@xxxxxxxxxxxxxxx > cc: linux-fsdevel@xxxxxxxxxxxxxxx > Link: https://lore.kernel.org/r/20241207021952.2978530-1-zilin@xxxxxxxxxx/ > --- > fs/netfs/direct_write.c | 1 - > 1 file changed, 1 deletion(-) >
