On Fri, Dec 6, 2024 at 6:40 PM Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx> wrote: > Do we really need this comment (for __must_check)? It looks like not > very informative. What do you think? That's a question of taste. For my taste, such comments are (not needed but) helpful; many similar comments exist in the Linux kernel. > I am not completely sure that it really needs to request compiler to > check that return value is processed. Do we really need to enforce it? Yes, should definitely be enforced. Callers which don't check the return value are 100% buggy.