Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ilya Dryomov <idryomov@xxxxxxxxx>
Subject: Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
From: Max Kellermann <max.kellermann@xxxxxxxxx>
Date: Thu, 5 Dec 2024 16:42:30 +0100
Cc: Alex Markuze <amarkuze@xxxxxxxxxx>, xiubli@xxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx
In-reply-to: <CAKPOu+-CpzPaY28MH9Og=mZTYmu99MUFTs+ezDZvud0HVb9PAw@mail.gmail.com>
References: <20241127212027.2704515-1-max.kellermann@ionos.com> <CAO8a2SiS16QFJ0mDtAW0ieuy9Nh6RjnP7-39q0oZKsVwNL=kRQ@mail.gmail.com> <CAKPOu+8qjHsPFFkVGu+V-ew7jQFNVz8G83Vj-11iB_Q9Z+YB5Q@mail.gmail.com> <CAKPOu+-rrmGWGzTKZ9i671tHuu0GgaCQTJjP5WPc7LOFhDSNZg@mail.gmail.com> <CAOi1vP-SSyTtLJ1_YVCxQeesY35TPxud8T=Wiw8Fk7QWEpu7jw@mail.gmail.com> <CAO8a2SiTOJkNs2y5C7fEkkGyYRmqjzUKMcnTEYXGU350U2fPzQ@mail.gmail.com> <CAKPOu+98G8YSBP8Nsj9WG3f5+HhVFE4Z5bTcgKrtTjrEwYtWRw@mail.gmail.com> <CAKPOu+9K314xvSn0TbY-L0oJ3CviVo=K2-=yxGPTUNEcBh3mbQ@mail.gmail.com> <CAO8a2Sgjw4AuhEDT8_0w--gFOqTLT2ajTLwozwC+b5_Hm=478w@mail.gmail.com> <CAKPOu+-UaSsfdmJhTMEiudCWkDf8KU7pQz0rt1eNfeqS2ERvZw@mail.gmail.com> <CAOi1vP8PRbO3853M-MgMZfPOR+9TS1CrW5AGVP0s06u_=Xq3bg@mail.gmail.com> <CAKPOu+-CpzPaY28MH9Og=mZTYmu99MUFTs+ezDZvud0HVb9PAw@mail.gmail.com>

On Thu, Dec 5, 2024 at 4:37 PM Max Kellermann <max.kellermann@xxxxxxxxx> wrote:
> btw. Alex's patch
> (https://github.com/ceph/ceph-client/commit/2a802a906f9c89f8ae4)
> introduces another memory leak

Sorry, that was wrong. The "break" only exits the inner "while" loop.
I got confused by nested loops.

References:
- [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Max Kellermann
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Alex Markuze
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Max Kellermann
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Max Kellermann
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Ilya Dryomov
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Alex Markuze
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Max Kellermann
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Max Kellermann
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Alex Markuze
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Max Kellermann
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Ilya Dryomov
- Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
  - From: Max Kellermann

Prev by Date: Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
Next by Date: [PATCH v2] fs/ceph/file: fix memory leaks in __ceph_sync_read()
Previous by thread: Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
Next by thread: [PATCH v2] fs/ceph/file: fix memory leaks in __ceph_sync_read()
Index(es):
- Date
- Thread

[Index of Archives] [CEPH Users] [Ceph Large] [Ceph Dev] [Information on CEPH] [Linux BTRFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]