Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




[removed most non-list recipients, it's just too much]

On 11/15/24 10:26 PM, Easwar Hariharan wrote:
This is a series that follows up on my previous series to introduce
secs_to_jiffies() and convert a few initial users.[1] In the review for
that series, Anna-Maria requested converting other users with
Coccinelle. This is part 1 that converts users of msecs_to_jiffies()
that use the multiply pattern of either of:
- msecs_to_jiffies(N*1000), or
- msecs_to_jiffies(N*MSEC_PER_SEC)

The entire conversion is made with Coccinelle in the script added in
patch 2. Some changes suggested by Coccinelle have been deferred to
later parts that will address other possible variant patterns.

CC: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>
Signed-off-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>

[1] https://lore.kernel.org/all/20241030-open-coded-timeouts-v3-0-9ba123facf88@xxxxxxxxxxxxxxxxxxx/
[2] https://lore.kernel.org/all/8734kngfni.fsf@somnus/

---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v1: https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v1-0-19aadc34941b@xxxxxxxxxxxxxxxxxxx

that is not a proper changelog, you were supposed to edit those
placeholder entries; please look around for examples

There is also just too much recipients. Please split up your patches
into smaller pieces. You will also learn the process on a smaller
sample.

And definitively please wait for 48h before reposting such big series.

Regarding code - you could also convert msecs_to_jiffies(const * HZ),
there are 10 that are greppable.


---
Easwar Hariharan (21):
       netfilter: conntrack: Cleanup timeout definitions
       coccinelle: misc: Add secs_to_jiffies script
       arm: pxa: Convert timeouts to use secs_to_jiffies()
       s390: kernel: Convert timeouts to use secs_to_jiffies()
       powerpc/papr_scm: Convert timeouts to secs_to_jiffies()
       mm: kmemleak: Convert timeouts to secs_to_jiffies()
       accel/habanalabs: Convert timeouts to secs_to_jiffies()
       drm/xe: Convert timeout to secs_to_jiffies()
       drm/etnaviv: Convert timeouts to secs_to_jiffies()
       scsi: lpfc: Convert timeouts to secs_to_jiffies()
       scsi: arcmsr: Convert timeouts to secs_to_jiffies()
       scsi: pm8001: Convert timeouts to secs_to_jiffies()
       xen/blkback: Convert timeouts to secs_to_jiffies()
       gve: Convert timeouts to secs_to_jiffies()
       wifi: ath11k: Convert timeouts to secs_to_jiffies()
       Bluetooth: MGMT: Convert timeouts to secs_to_jiffies()
       staging: vc04_services: Convert timeouts to secs_to_jiffies()
       ceph: Convert timeouts to secs_to_jiffies()
       livepatch: Convert timeouts to secs_to_jiffies()
       ALSA: line6: Convert timeouts to secs_to_jiffies()
       nfp: Convert timeouts to secs_to_jiffies()

  arch/arm/mach-pxa/sharpsl_pm.c                      |  6 +++---
  arch/powerpc/platforms/pseries/papr_scm.c           |  2 +-
  arch/s390/kernel/lgr.c                              |  3 ++-
  arch/s390/kernel/time.c                             |  4 ++--
  arch/s390/kernel/topology.c                         |  2 +-
  drivers/accel/habanalabs/common/device.c            |  2 +-
  drivers/accel/habanalabs/common/habanalabs_drv.c    |  3 +--
  drivers/block/xen-blkback/blkback.c                 |  2 +-
  drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c            |  2 +-
  drivers/gpu/drm/xe/xe_device.c                      |  2 +-
  drivers/net/ethernet/google/gve/gve_tx_dqo.c        |  6 ++----
  drivers/net/ethernet/netronome/nfp/nfp_net_common.c |  2 +-
  drivers/net/wireless/ath/ath11k/debugfs.c           |  2 +-
  drivers/scsi/arcmsr/arcmsr_hba.c                    |  2 +-
  drivers/scsi/lpfc/lpfc_init.c                       | 18 +++++++++---------
  drivers/scsi/lpfc/lpfc_nportdisc.c                  |  8 ++++----
  drivers/scsi/lpfc/lpfc_nvme.c                       |  2 +-
  drivers/scsi/lpfc/lpfc_sli.c                        |  4 ++--
  drivers/scsi/lpfc/lpfc_vmid.c                       |  2 +-
  drivers/scsi/pm8001/pm8001_init.c                   |  2 +-
  .../vc04_services/bcm2835-audio/bcm2835-vchiq.c     |  2 +-
  fs/ceph/quota.c                                     |  2 +-
  mm/kmemleak.c                                       |  4 ++--
  net/bluetooth/mgmt.c                                |  2 +-
  net/netfilter/nf_conntrack_proto_sctp.c             | 21 ++++++++-------------
  samples/livepatch/livepatch-callbacks-busymod.c     |  2 +-
  samples/livepatch/livepatch-shadow-fix1.c           |  2 +-
  samples/livepatch/livepatch-shadow-mod.c            | 10 +++++-----
  scripts/coccinelle/misc/secs_to_jiffies.cocci       | 21 +++++++++++++++++++++
  sound/usb/line6/toneport.c                          |  2 +-
  30 files changed, 79 insertions(+), 65 deletions(-)
---
base-commit: 2d5404caa8c7bb5c4e0435f94b28834ae5456623
change-id: 20241112-converge-secs-to-jiffies-d99d1016bd11

Best regards,





[Index of Archives]     [CEPH Users]     [Ceph Large]     [Ceph Dev]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux