Hi Abhinav, kernel test robot noticed the following build errors: [auto build test ERROR on net/main] url: https://github.com/intel-lab-lkp/linux/commits/Abhinav-Jain/libceph-Make-the-arguments-const-as-per-the-TODO/20240812-045647 base: net/main patch link: https://lore.kernel.org/r/20240811205509.1089027-1-jain.abhinav177%40gmail.com patch subject: [PATCH net v2] libceph: Make the arguments const as per the TODO config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20240812/202408121452.qS7GNcws-lkp@xxxxxxxxx/config) compiler: arceb-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240812/202408121452.qS7GNcws-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408121452.qS7GNcws-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from include/linux/array_size.h:5, from include/linux/string.h:6, from include/linux/ceph/ceph_debug.h:7, from net/ceph/crypto.c:3: net/ceph/crypto.c: In function 'ceph_crypto_key_decode': >> net/ceph/crypto.c:93:26: error: passing argument 1 of 'ceph_has_room' from incompatible pointer type [-Werror=incompatible-pointer-types] 93 | ceph_decode_need(p, end, 2*sizeof(u16) + sizeof(key->created), bad); | ^ | | | const void ** include/linux/compiler.h:76:45: note: in definition of macro 'likely' 76 | # define likely(x) __builtin_expect(!!(x), 1) | ^ net/ceph/crypto.c:93:9: note: in expansion of macro 'ceph_decode_need' 93 | ceph_decode_need(p, end, 2*sizeof(u16) + sizeof(key->created), bad); | ^~~~~~~~~~~~~~~~ In file included from net/ceph/crypto.c:16: include/linux/ceph/decode.h:52:41: note: expected 'void **' but argument is of type 'const void **' 52 | static inline bool ceph_has_room(void **p, void *end, size_t n) | ~~~~~~~^ net/ceph/crypto.c:93:29: warning: passing argument 2 of 'ceph_has_room' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 93 | ceph_decode_need(p, end, 2*sizeof(u16) + sizeof(key->created), bad); | ^~~ include/linux/compiler.h:76:45: note: in definition of macro 'likely' 76 | # define likely(x) __builtin_expect(!!(x), 1) | ^ net/ceph/crypto.c:93:9: note: in expansion of macro 'ceph_decode_need' 93 | ceph_decode_need(p, end, 2*sizeof(u16) + sizeof(key->created), bad); | ^~~~~~~~~~~~~~~~ include/linux/ceph/decode.h:52:50: note: expected 'void *' but argument is of type 'const void *' 52 | static inline bool ceph_has_room(void **p, void *end, size_t n) | ~~~~~~^~~ >> net/ceph/crypto.c:94:36: error: passing argument 1 of 'ceph_decode_16' from incompatible pointer type [-Werror=incompatible-pointer-types] 94 | key->type = ceph_decode_16(p); | ^ | | | const void ** include/linux/ceph/decode.h:31:41: note: expected 'void **' but argument is of type 'const void **' 31 | static inline u16 ceph_decode_16(void **p) | ~~~~~~~^ >> net/ceph/crypto.c:95:26: error: passing argument 1 of 'ceph_decode_copy' from incompatible pointer type [-Werror=incompatible-pointer-types] 95 | ceph_decode_copy(p, &key->created, sizeof(key->created)); | ^ | | | const void ** include/linux/ceph/decode.h:43:44: note: expected 'void **' but argument is of type 'const void **' 43 | static inline void ceph_decode_copy(void **p, void *pv, size_t n) | ~~~~~~~^ net/ceph/crypto.c:96:35: error: passing argument 1 of 'ceph_decode_16' from incompatible pointer type [-Werror=incompatible-pointer-types] 96 | key->len = ceph_decode_16(p); | ^ | | | const void ** include/linux/ceph/decode.h:31:41: note: expected 'void **' but argument is of type 'const void **' 31 | static inline u16 ceph_decode_16(void **p) | ~~~~~~~^ net/ceph/crypto.c:97:26: error: passing argument 1 of 'ceph_has_room' from incompatible pointer type [-Werror=incompatible-pointer-types] 97 | ceph_decode_need(p, end, key->len, bad); | ^ | | | const void ** include/linux/compiler.h:76:45: note: in definition of macro 'likely' 76 | # define likely(x) __builtin_expect(!!(x), 1) | ^ net/ceph/crypto.c:97:9: note: in expansion of macro 'ceph_decode_need' 97 | ceph_decode_need(p, end, key->len, bad); | ^~~~~~~~~~~~~~~~ include/linux/ceph/decode.h:52:41: note: expected 'void **' but argument is of type 'const void **' 52 | static inline bool ceph_has_room(void **p, void *end, size_t n) | ~~~~~~~^ net/ceph/crypto.c:97:29: warning: passing argument 2 of 'ceph_has_room' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 97 | ceph_decode_need(p, end, key->len, bad); | ^~~ include/linux/compiler.h:76:45: note: in definition of macro 'likely' 76 | # define likely(x) __builtin_expect(!!(x), 1) | ^ net/ceph/crypto.c:97:9: note: in expansion of macro 'ceph_decode_need' 97 | ceph_decode_need(p, end, key->len, bad); | ^~~~~~~~~~~~~~~~ include/linux/ceph/decode.h:52:50: note: expected 'void *' but argument is of type 'const void *' 52 | static inline bool ceph_has_room(void **p, void *end, size_t n) | ~~~~~~^~~ net/ceph/crypto.c:98:31: warning: passing argument 2 of 'set_secret' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 98 | ret = set_secret(key, *p); | ^~ net/ceph/crypto.c:23:58: note: expected 'void *' but argument is of type 'const void *' 23 | static int set_secret(struct ceph_crypto_key *key, void *buf) | ~~~~~~^~~ net/ceph/crypto.c:99:26: warning: passing argument 1 of 'memzero_explicit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 99 | memzero_explicit(*p, key->len); | ^~ include/linux/string.h:356:43: note: expected 'void *' but argument is of type 'const void *' 356 | static inline void memzero_explicit(void *s, size_t count) | ~~~~~~^ during RTL pass: mach net/ceph/crypto.c: In function 'ceph_crypto_key_unarmor': net/ceph/crypto.c:134:1: internal compiler error: in arc_ifcvt, at config/arc/arc.cc:9703 134 | } | ^ 0x5b78c1 arc_ifcvt /tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/config/arc/arc.cc:9703 0xe431b4 arc_reorg /tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/config/arc/arc.cc:8552 0xaed299 execute /tmp/build-crosstools-gcc-13.2.0-binutils-2.41/gcc/gcc-13.2.0/gcc/reorg.cc:3927 Please submit a full bug report, with preprocessed source (by using -freport-bug). Please include the complete backtrace with any bug report. See <https://gcc.gnu.org/bugs/> for instructions. vim +/ceph_has_room +93 net/ceph/crypto.c 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 88 19c7b44529ef1b net/ceph/crypto.c Abhinav Jain 2024-08-12 89 int ceph_crypto_key_decode(struct ceph_crypto_key *key, const void **p, const void *end) 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 90 { 7af3ea189a9a13 net/ceph/crypto.c Ilya Dryomov 2016-12-02 91 int ret; 7af3ea189a9a13 net/ceph/crypto.c Ilya Dryomov 2016-12-02 92 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 @93 ceph_decode_need(p, end, 2*sizeof(u16) + sizeof(key->created), bad); 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 @94 key->type = ceph_decode_16(p); 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 @95 ceph_decode_copy(p, &key->created, sizeof(key->created)); 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 96 key->len = ceph_decode_16(p); 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 97 ceph_decode_need(p, end, key->len, bad); 7af3ea189a9a13 net/ceph/crypto.c Ilya Dryomov 2016-12-02 98 ret = set_secret(key, *p); 10f42b3e648377 net/ceph/crypto.c Ilya Dryomov 2020-12-22 99 memzero_explicit(*p, key->len); 7af3ea189a9a13 net/ceph/crypto.c Ilya Dryomov 2016-12-02 100 *p += key->len; 7af3ea189a9a13 net/ceph/crypto.c Ilya Dryomov 2016-12-02 101 return ret; 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 102 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 103 bad: 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 104 dout("failed to decode crypto key\n"); 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 105 return -EINVAL; 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 106 } 8b6e4f2d8b21c2 fs/ceph/crypto.c Sage Weil 2010-02-02 107 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
