Re: [PATCH] ceph: periodically flush the cap releases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 10, 2024 at 5:57 PM <xiubli@xxxxxxxxxx> wrote:
>
> From: Xiubo Li <xiubli@xxxxxxxxxx>
>
> The MDS could be waiting the caps releases infinitely in some corner
> case and then reporting the caps revoke stuck warning. To fix this
> we should periodically flush the cap releases.
>
> URL: https://tracker.ceph.com/issues/57244
> Signed-off-by: Xiubo Li <xiubli@xxxxxxxxxx>
> ---
>  fs/ceph/mds_client.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index c750ebcad972..b7fcaa6e28b4 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -5474,6 +5474,8 @@ static void delayed_work(struct work_struct *work)
>                 }
>                 mutex_unlock(&mdsc->mutex);
>
> +               ceph_flush_cap_releases(mdsc, s);
> +
>                 mutex_lock(&s->s_mutex);
>                 if (renew_caps)
>                         send_renew_caps(mdsc, s);
> --
> 2.43.0
>

LGTM.

Reviewed-by: Venky Shankar <vshankar@xxxxxxxxxx>

-- 
Cheers,
Venky






[Index of Archives]     [CEPH Users]     [Ceph Large]     [Ceph Dev]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux