Re: [PATCH 02/14] ubd: untagle discard vs write zeroes not support handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 02/14] ubd: untagle discard vs write zeroes not support handling
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Thu, 13 Jun 2024 21:36:04 -0400
Cc: Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Dongsheng Yang <dongsheng.yang@xxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, Bart Van Assche <bvanassche@xxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>
In-reply-to: <20240531074837.1648501-3-hch@lst.de> (Christoph Hellwig's message of "Fri, 31 May 2024 09:47:57 +0200")
Organization: Oracle Corporation
References: <20240531074837.1648501-1-hch@lst.de> <20240531074837.1648501-3-hch@lst.de>

Christoph,

> Discard and Write Zeroes are different operation and implemented
> by different fallocate opcodes for ubd.  If one fails the other one
> can work and vice versa.
>
> Split the code to disable the operations in ubd_handler to only
> disable the operation that actually failed.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- convert the SCSI ULDs to the atomic queue limits API v2
  - From: Christoph Hellwig
- [PATCH 02/14] ubd: untagle discard vs write zeroes not support handling
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 03/14] rbd: increase io_opt again
Next by Date: Re: [PATCH 04/14] block: take io_opt and io_min into account for max_sectors
Previous by thread: [PATCH 02/14] ubd: untagle discard vs write zeroes not support handling
Next by thread: Re: [PATCH 02/14] ubd: untagle discard vs write zeroes not support handling
Index(es):
- Date
- Thread

[Index of Archives] [CEPH Users] [Ceph Large] [Ceph Dev] [Information on CEPH] [Linux BTRFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]