Re: [PATCH 01/12] ubd: untagle discard vs write zeroes not support handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH 01/12] ubd: untagle discard vs write zeroes not support handling
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Thu, 30 May 2024 12:44:46 -0700
Cc: Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Dongsheng Yang <dongsheng.yang@xxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx
In-reply-to: <20240529050507.1392041-2-hch@lst.de>
References: <20240529050507.1392041-1-hch@lst.de> <20240529050507.1392041-2-hch@lst.de>
User-agent: Mozilla Thunderbird

On 5/28/24 22:04, Christoph Hellwig wrote:

Discard and Write Zeroes are different operation and implemented
by different fallocate opcodes for ubd.  If one fails the other one
can work and vice versa.

Split the code to disable the operations in ubd_handler to only
disable the operation that actually failed.


Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

References:
- convert the SCSI ULDs to the atomic queue limits API
  - From: Christoph Hellwig
- [PATCH 01/12] ubd: untagle discard vs write zeroes not support handling
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 0/4] bugfix: Introduce sendpages_ok() to check sendpage_ok() on contiguous pages
Next by Date: Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors
Previous by thread: Re: [PATCH 01/12] ubd: untagle discard vs write zeroes not support handling
Next by thread: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors
Index(es):
- Date
- Thread

[Index of Archives] [CEPH Users] [Ceph Large] [Ceph Dev] [Information on CEPH] [Linux BTRFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]