On 6/13/23 16:39, Ilya Dryomov wrote:
On Mon, Jun 12, 2023 at 1:46 PM <xiubli@xxxxxxxxxx> wrote:
From: Xiubo Li <xiubli@xxxxxxxxxx>
This will help print the client's global_id in debug logs.
Hi Xiubo,
There is a related concern that clients can belong to different
clusters, in which case their global IDs might clash. If you chose
to disregard that as an unlikely scenario, it's probably fine, but
it would be nice to make that explicit in the commit message.
If account for that, the identifier block could look like:
[<cluster fsid> <gid>]
The fsid string is a little long:
[5ea1e13c-4034-426c-bf8f-8a3a70d9e812 4236]
Maybe we could just print part of that as:
[5ea1e13c.. 4236]
?
instead of:
[client.<gid>]
The "client." string prefix seems a bit redundant since the kernel
client's entity is always CEPH_ENTITY_TYPE_CLIENT. If you like it
anyway, I would at least get rid of the dot at the end to align with
how it's presented elsewhere (e.g. debugfs directory name or
"ceph.client_id" xattr).
Sure, I will remove it.
Thanks
- Xiubo
Thanks,
Ilya
