On Mon, Jun 5, 2023 at 3:53 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Fri, Jun 02, 2023 at 02:40:27PM +0200, Christian Brauner wrote: > > On Wed, May 24, 2023 at 05:33:03PM +0200, Alexander Mikhalitsyn wrote: > > > These helpers are required to support idmapped mounts in the Cephfs. > > > > > > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@xxxxxxxxxxxxx> > > > --- > > > > It's fine by me to export them. The explicit contract is that _nothing > > and absolutely nothing_ outside of core VFS code can directly peak into > > struct mnt_idmap internals. That's the only invariant we care about.o > > It would be good if we could keep all these somewhat internal exports > as EXPORT_SYMBOL_GPL, though. Dear Christoph, Well noticed! Thanks, I will do it. Kind regards, Alex >
