On 02/01/2023 19:50, Ilya Dryomov wrote:
On Wed, Dec 14, 2022 at 4:35 AM <xiubli@xxxxxxxxxx> wrote:
From: Xiubo Li <xiubli@xxxxxxxxxx>
Changed in V5:
- s/fl_inode/inode/
Changed in V4:
- repeat the afs in fs.h instead of adding ceph specific header file
Changed in V3:
- switched to vfs_inode_has_locks() helper to fix another ceph file lock
bug, thanks Jeff!
- this patch series is based on Jeff's previous VFS lock patch:
https://patchwork.kernel.org/project/ceph-devel/list/?series=695950
Changed in V2:
- switch to file_lock.fl_u to fix the race bug
- and the most code will be in the ceph layer
Xiubo Li (2):
ceph: switch to vfs_inode_has_locks() to fix file lock bug
ceph: add ceph specific member support for file_lock
fs/ceph/caps.c | 2 +-
fs/ceph/locks.c | 24 ++++++++++++++++++------
fs/ceph/super.h | 1 -
include/linux/fs.h | 3 +++
4 files changed, 22 insertions(+), 8 deletions(-)
--
2.31.1
Hi Xiubo,
I have adjusted the title of the second patch to actually reflect its
purpose: "ceph: avoid use-after-free in ceph_fl_release_lock()". With
that:
Reviewed-by: Ilya Dryomov <idryomov@xxxxxxxxx>
Hi Ilya,
Sure. Looks better.
I will revise it.
Thanks
- Xiubo
Thanks,
Ilya