On Mon, 2022-09-19 at 09:53 +1000, Dave Chinner wrote: > On Fri, Sep 16, 2022 at 11:11:34AM -0400, Jeff Layton wrote: > > On Fri, 2022-09-16 at 07:36 -0400, Jeff Layton wrote: > > > On Fri, 2022-09-16 at 02:54 -0400, Theodore Ts'o wrote: > > > > On Fri, Sep 16, 2022 at 08:23:55AM +1000, NeilBrown wrote: > > > > > > > If the answer is that 'all values change', then why store the crash > > > > > > > counter in the inode at all? Why not just add it as an offset when > > > > > > > you're generating the user-visible change attribute? > > > > > > > > > > > > > > i.e. statx.change_attr = inode->i_version + (crash counter * offset) > > > > > > > > I had suggested just hashing the crash counter with the file system's > > > > on-disk i_version number, which is essentially what you are suggested. > > > > > > > > > > Yes, if we plan to ensure that all the change attrs change after a > > > > > > crash, we can do that. > > > > > > > > > > > > So what would make sense for an offset? Maybe 2**12? One would hope that > > > > > > there wouldn't be more than 4k increments before one of them made it to > > > > > > disk. OTOH, maybe that can happen with teeny-tiny writes. > > > > > > > > > > Leave it up the to filesystem to decide. The VFS and/or NFSD should > > > > > have not have part in calculating the i_version. It should be entirely > > > > > in the filesystem - though support code could be provided if common > > > > > patterns exist across filesystems. > > > > > > > > Oh, *heck* no. This parameter is for the NFS implementation to > > > > decide, because it's NFS's caching algorithms which are at stake here. > > > > > > > > As a the file system maintainer, I had offered to make an on-disk > > > > "crash counter" which would get updated when the journal had gotten > > > > replayed, in addition to the on-disk i_version number. This will be > > > > available for the Linux implementation of NFSD to use, but that's up > > > > to *you* to decide how you want to use them. > > > > > > > > I was perfectly happy with hashing the crash counter and the i_version > > > > because I had assumed that not *that* much stuff was going to be > > > > cached, and so invalidating all of the caches in the unusual case > > > > where there was a crash was acceptable. After all it's a !@#?!@ > > > > cache. Caches sometimmes get invalidated. "That is the order of > > > > things." (as Ramata'Klan once said in "Rocks and Shoals") > > > > > > > > But if people expect that multiple TB's of data is going to be stored; > > > > that cache invalidation is unacceptable; and that a itsy-weeny chance > > > > of false negative failures which might cause data corruption might be > > > > acceptable tradeoff, hey, that's for the system which is providing > > > > caching semantics to determine. > > > > > > > > PLEASE don't put this tradeoff on the file system authors; I would > > > > much prefer to leave this tradeoff in the hands of the system which is > > > > trying to do the caching. > > > > > > > > > > Yeah, if we were designing this from scratch, I might agree with leaving > > > more up to the filesystem, but the existing users all have pretty much > > > the same needs. I'm going to plan to try to keep most of this in the > > > common infrastructure defined in iversion.h. > > > > > > Ted, for the ext4 crash counter, what wordsize were you thinking? I > > > doubt we'll be able to use much more than 32 bits so a larger integer is > > > probably not worthwhile. There are several holes in struct super_block > > > (at least on x86_64), so adding this field to the generic structure > > > needn't grow it. > > > > That said, now that I've taken a swipe at implementing this, I need more > > information than just the crash counter. We need to multiply the crash > > counter with a reasonable estimate of the maximum number of individual > > writes that could occur between an i_version being incremented and that > > value making it to the backing store. > > > > IOW, given a write that bumps the i_version to X, how many more write > > calls could race in before X makes it to the platter? I took a SWAG and > > said 4k in an earlier email, but I don't really have a way to know, and > > that could vary wildly with different filesystems and storage. > > > > What I'd like to see is this in struct super_block: > > > > u32 s_version_offset; > > u64 s_version_salt; > IDK...it _is_ an offset since we're folding it in with addition, and it has a real meaning. Filesystems do need to be cognizant of that fact, I think. Also does anyone have a preference on doing this vs. a get_version_salt or get_version_offset sb operation? I figured the value should be mostly static so it'd be nice to avoid an operation for it. > > ...and then individual filesystems can calculate: > > > > crash_counter * max_number_of_writes > > > > and put the correct value in there at mount time. > > Other filesystems might not have a crash counter but have other > information that can be substituted, like a mount counter or a > global change sequence number that is guaranteed to increment from > one mount to the next. > The problem there is that you're going to cause the invalidation of all of the NFS client's cached regular files, even on clean server reboots. That's not a desirable outcome. > Further, have you thought about what "max number of writes" might > be in ten years time? e.g. what happens if a filesysetm as "max > number of writes" being greater than 2^32? I mean, we already have > machines out there running Linux with 64-128TB of physical RAM, so > it's already practical to hold > 2^32 individual writes to a single > inode that each bump i_version in memory.... > So when we consider this sort of scale, the "crash counter * max > writes" scheme largely falls apart because "max writes" is a really > large number to begin with. We're going to be stuck with whatever > algorithm is decided on for the foreseeable future, so we must > recognise that _we've already overrun 32 bit counter schemes_ in > terms of tracking "i_version changes in memory vs what we have on > disk". > > Hence I really think that we should be leaving the implementation of > the salt value to the individual filesysetms as different > filesytsems are aimed at different use cases and so may not > necessarily have to all care about the same things (like 2^32 bit > max write overruns). All the high level VFS code then needs to do > is add the two together: > > statx.change_attr = inode->i_version + sb->s_version_salt; > Yeah, I have thought about that. I was really hoping that file systems wouldn't leave so many ephemeral changes lying around before logging something. It's actually not as bad as it sounds. You'd need that number of inode changes in memory + queries of i_version, alternating. When there are no queries, nothing changes. But, the number of queries is hard to gauge too as it's very dependent on workload, hardware, etc. If the sky really is the limit on unlogged inode changes, then what do you suggest? One idea: We could try to kick off a write_inode in the background when the i_version gets halfway to the limit. Eventually the nfs server could just return NFS4ERR_DELAY on a GETATTR if it looked like the reported version was going to cross the threshold. It'd be ugly, but hopefully wouldn't happen much if things are tuned well. Tracking that info might be expensive though. We'd need at least another u64 field in struct inode for the latest on-disk version. Maybe we can keep that in the fs-specific part of the inode somehow so we don't need to grow generic struct inode? -- Jeff Layton <jlayton@xxxxxxxxxx>
