On Fri, Jul 1, 2022 at 10:22 AM Zhang Jiaming <jiaming@xxxxxxxxxxxx> wrote:
>
> There is a typo (writeable) in comments and dout information.
> Fix it.
>
> Signed-off-by: Zhang Jiaming <jiaming@xxxxxxxxxxxx>
> ---
> fs/ceph/addr.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 6dee88815491..083c5b6cae9e 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -565,7 +565,7 @@ static int writepage_nounlock(struct page *page, struct writeback_control *wbc)
>
> dout("writepage %p idx %lu\n", page, page->index);
>
> - /* verify this is a writeable snap context */
> + /* verify this is a writable snap context */
> snapc = page_snap_context(page);
> if (!snapc) {
> dout("writepage %p page %p not dirty?\n", inode, page);
> @@ -573,7 +573,7 @@ static int writepage_nounlock(struct page *page, struct writeback_control *wbc)
> }
> oldest = get_oldest_context(inode, &ceph_wbc, snapc);
> if (snapc->seq > oldest->seq) {
> - dout("writepage %p page %p snapc %p not writeable - noop\n",
> + dout("writepage %p page %p snapc %p not writable - noop\n",
> inode, page, snapc);
> /* we should only noop if called by kswapd */
> WARN_ON(!(current->flags & PF_MEMALLOC));
> @@ -860,7 +860,7 @@ static int ceph_writepages_start(struct address_space *mapping,
> } else if (!ceph_wbc.head_snapc) {
> /* Do not respect wbc->range_{start,end}. Dirty pages
> * in that range can be associated with newer snapc.
> - * They are not writeable until we write all dirty pages
> + * They are not writable until we write all dirty pages
> * associated with 'snapc' get written */
> if (index > 0)
> should_loop = true;
> @@ -1219,7 +1219,7 @@ static int ceph_writepages_start(struct address_space *mapping,
>
>
> /*
> - * See if a given @snapc is either writeable, or already written.
> + * See if a given @snapc is either writable, or already written.
> */
> static int context_is_writeable_or_written(struct inode *inode,
> struct ceph_snap_context *snapc)
> @@ -1265,18 +1265,18 @@ ceph_find_incompatible(struct page *page)
>
> /*
> * this page is already dirty in another (older) snap
> - * context! is it writeable now?
> + * context! is it writable now?
> */
> oldest = get_oldest_context(inode, NULL, NULL);
> if (snapc->seq > oldest->seq) {
> - /* not writeable -- return it for the caller to deal with */
> + /* not writable -- return it for the caller to deal with */
> ceph_put_snap_context(oldest);
> dout(" page %p snapc %p not current or oldest\n", page, snapc);
> return ceph_get_snap_context(snapc);
> }
> ceph_put_snap_context(oldest);
>
> - /* yay, writeable, do it now (without dropping page lock) */
> + /* yay, writable, do it now (without dropping page lock) */
> dout(" page %p snapc %p not current, but oldest\n", page, snapc);
> if (clear_page_dirty_for_io(page)) {
> int r = writepage_nounlock(page, NULL);
> --
> 2.25.1
>
Hi Zhang,
https://en.wiktionary.org/wiki/writeable says that "writeable" is an
alternative spelling of "writable". It is especially common in computer
science -- there are hundreds of instances just in the kernel sources
along.
Thanks,
Ilya
