[ceph-client:testing 7/14] fs/ceph/addr.c:125:9: error: implicit declaration of function 'VM_WARN_ON_FOLIO'; did you mean 'VM_WARN_ON_ONCE'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://github.com/ceph/ceph-client.git testing
head:   3e303a58e3a89d254098138aa8488872bf73c9a4
commit: 00043f493521923e81e179ef2e01a47941b07ef2 [7/14] ceph: switch back to testing for NULL folio->private in ceph_dirty_folio
config: i386-randconfig-a005 (https://download.01.org/0day-ci/archive/20220612/202206122152.diN4bDDL-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/ceph/ceph-client/commit/00043f493521923e81e179ef2e01a47941b07ef2
        git remote add ceph-client https://github.com/ceph/ceph-client.git
        git fetch --no-tags ceph-client testing
        git checkout 00043f493521923e81e179ef2e01a47941b07ef2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   fs/ceph/addr.c: In function 'ceph_dirty_folio':
>> fs/ceph/addr.c:125:9: error: implicit declaration of function 'VM_WARN_ON_FOLIO'; did you mean 'VM_WARN_ON_ONCE'? [-Werror=implicit-function-declaration]
     125 |         VM_WARN_ON_FOLIO(folio->private, folio);
         |         ^~~~~~~~~~~~~~~~
         |         VM_WARN_ON_ONCE
   cc1: some warnings being treated as errors


vim +125 fs/ceph/addr.c

    74	
    75	/*
    76	 * Dirty a page.  Optimistically adjust accounting, on the assumption
    77	 * that we won't race with invalidate.  If we do, readjust.
    78	 */
    79	static bool ceph_dirty_folio(struct address_space *mapping, struct folio *folio)
    80	{
    81		struct inode *inode;
    82		struct ceph_inode_info *ci;
    83		struct ceph_snap_context *snapc;
    84	
    85		if (folio_test_dirty(folio)) {
    86			dout("%p dirty_folio %p idx %lu -- already dirty\n",
    87			     mapping->host, folio, folio->index);
    88			VM_BUG_ON_FOLIO(!folio_test_private(folio), folio);
    89			return false;
    90		}
    91	
    92		inode = mapping->host;
    93		ci = ceph_inode(inode);
    94	
    95		/* dirty the head */
    96		spin_lock(&ci->i_ceph_lock);
    97		BUG_ON(ci->i_wr_ref == 0); // caller should hold Fw reference
    98		if (__ceph_have_pending_cap_snap(ci)) {
    99			struct ceph_cap_snap *capsnap =
   100					list_last_entry(&ci->i_cap_snaps,
   101							struct ceph_cap_snap,
   102							ci_item);
   103			snapc = ceph_get_snap_context(capsnap->context);
   104			capsnap->dirty_pages++;
   105		} else {
   106			BUG_ON(!ci->i_head_snapc);
   107			snapc = ceph_get_snap_context(ci->i_head_snapc);
   108			++ci->i_wrbuffer_ref_head;
   109		}
   110		if (ci->i_wrbuffer_ref == 0)
   111			ihold(inode);
   112		++ci->i_wrbuffer_ref;
   113		dout("%p dirty_folio %p idx %lu head %d/%d -> %d/%d "
   114		     "snapc %p seq %lld (%d snaps)\n",
   115		     mapping->host, folio, folio->index,
   116		     ci->i_wrbuffer_ref-1, ci->i_wrbuffer_ref_head-1,
   117		     ci->i_wrbuffer_ref, ci->i_wrbuffer_ref_head,
   118		     snapc, snapc->seq, snapc->num_snaps);
   119		spin_unlock(&ci->i_ceph_lock);
   120	
   121		/*
   122		 * Reference snap context in folio->private.  Also set
   123		 * PagePrivate so that we get invalidate_folio callback.
   124		 */
 > 125		VM_WARN_ON_FOLIO(folio->private, folio);
   126		folio_attach_private(folio, snapc);
   127	
   128		return ceph_fscache_dirty_folio(mapping, folio);
   129	}
   130	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp



[Index of Archives]     [CEPH Users]     [Ceph Large]     [Ceph Dev]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux