Jeff Layton <jlayton@xxxxxxxxxx> writes: > On Thu, 2022-05-26 at 14:07 +0800, Xiubo Li wrote: >> This macro was added but never be used. And check the ceph code >> there has another CEPHFS_FEATURES_MDS_REQUIRED but always be empty. >> >> We should clean up all this related code, which make no sense but >> introducing confusion. >> >> Signed-off-by: Xiubo Li <xiubli@xxxxxxxxxx> >> --- >> fs/ceph/mds_client.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h >> index 636fcf4503e0..d8ec2ac93da3 100644 >> --- a/fs/ceph/mds_client.h >> +++ b/fs/ceph/mds_client.h >> @@ -42,7 +42,6 @@ enum ceph_feature_type { >> CEPHFS_FEATURE_DELEG_INO, \ >> CEPHFS_FEATURE_METRIC_COLLECT, \ >> } >> -#define CEPHFS_FEATURES_CLIENT_REQUIRED {} >> >> /* >> * Some lock dependencies: > > Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx> Yep, this makes sense. Reviewed-by: Luís Henriques <lhenriques@xxxxxxx> Cheers, -- Luís