Re: [PATCH] libceph: drop last_piece flag from ceph_msg_data_cursor

[kernel test robot <lkp@xxxxxxxxx>]

Hi Jeff,

I love your patch! Perhaps something to improve:

[auto build test WARNING on ceph-client/for-linus]
[also build test WARNING on v5.18 next-20220524]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Jeff-Layton/libceph-drop-last_piece-flag-from-ceph_msg_data_cursor/20220525-060709
base:   https://github.com/ceph/ceph-client.git for-linus
config: xtensa-randconfig-s031-20220524 (https://download.01.org/0day-ci/archive/20220525/202205251055.ijbnX88Q-lkp@xxxxxxxxx/config)
compiler: xtensa-linux-gcc (GCC) 11.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-14-g5a0004b5-dirty
        # https://github.com/intel-lab-lkp/linux/commit/09a57bbfef50219b0f819adc621516e6b3344fe4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jeff-Layton/libceph-drop-last_piece-flag-from-ceph_msg_data_cursor/20220525-060709
        git checkout 09a57bbfef50219b0f819adc621516e6b3344fe4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=xtensa SHELL=/bin/bash net/ceph/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)
   net/ceph/messenger.c: note: in included file (through arch/xtensa/include/asm/bitops.h, include/linux/bitops.h, include/linux/log2.h, ...):
   arch/xtensa/include/asm/processor.h:103:2: sparse: sparse: Unsupported xtensa ABI
   arch/xtensa/include/asm/processor.h:133:2: sparse: sparse: Unsupported Xtensa ABI
>> net/ceph/messenger.c:858:19: sparse: sparse: incompatible types in comparison expression (different type sizes):
>> net/ceph/messenger.c:858:19: sparse:    unsigned int *
>> net/ceph/messenger.c:858:19: sparse:    unsigned long *
   net/ceph/messenger.c:931:19: sparse: sparse: incompatible types in comparison expression (different type sizes):
   net/ceph/messenger.c:931:19: sparse:    unsigned int *
   net/ceph/messenger.c:931:19: sparse:    unsigned long *

vim +858 net/ceph/messenger.c

   845	
   846	static struct page *
   847	ceph_msg_data_pages_next(struct ceph_msg_data_cursor *cursor,
   848						size_t *page_offset, size_t *length)
   849	{
   850		struct ceph_msg_data *data = cursor->data;
   851	
   852		BUG_ON(data->type != CEPH_MSG_DATA_PAGES);
   853	
   854		BUG_ON(cursor->page_index >= cursor->page_count);
   855		BUG_ON(cursor->page_offset >= PAGE_SIZE);
   856	
   857		*page_offset = cursor->page_offset;
 > 858		*length = min(cursor->resid, PAGE_SIZE - *page_offset);
   859		return data->pages[cursor->page_index];
   860	}
   861	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp